fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21494 )
Change subject: gprs_ns2: Use TLVP_PRES_LEN instead of TLVP_PRESENT ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21494/2/src/gb/gprs_ns2.c File src/gb/gprs_ns2.c: https://gerrit.osmocom.org/c/libosmocore/+/21494/2/src/gb/gprs_ns2.c@596 PS2, Line 596: LOGP(DLNS, LOGL_NOTICE, "NSEI=%u Rejecting message without NSVCI. Tx NS STATUS (cause=%s)\n", This logging statement looks wrong: we check if NSEI is present, and log that NSVCI is absent? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21494 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4c438bc82ea6a48243db568f96a234adf784dc0b Gerrit-Change-Number: 21494 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Fri, 04 Dec 2020 09:35:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
