pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/21589 )

Change subject: ns2: Accept NS-UNBLOCK-ACK in UNBLOCKED state
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/21589/1/src/gb/gprs_ns2_vc_fsm.c
File src/gb/gprs_ns2_vc_fsm.c:

https://gerrit.osmocom.org/c/libosmocore/+/21589/1/src/gb/gprs_ns2_vc_fsm.c@403
PS1, Line 403:          .in_event_mask = S(GPRS_NS2_EV_BLOCK) | 
S(GPRS_NS2_EV_UNBLOCK_ACK),
> this file (which I didn't write) already isn't formatted this way, and this 
> patch just follows the e […]
Only some of the lines are wrong, others are good, so I'm asking simply not to 
make it worse



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21589
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icc4d960ddad82e3ebbf571d8ff9f24854b52a946
Gerrit-Change-Number: 21589
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 08 Dec 2020 09:40:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to