pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21598 )
Change subject: gb: Add beginnings of a new BSSGP implementation ...................................................................... Patch Set 3: (4 comments) https://gerrit.osmocom.org/c/libosmocore/+/21598/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/21598/3//COMMIT_MSG@18 PS3, Line 18: bssgp_bvc_fsm.c is a genric implementation of the BSSGP BVC generic https://gerrit.osmocom.org/c/libosmocore/+/21598/3/src/gb/bssgp_bvc_fsm.c File src/gb/bssgp_bvc_fsm.c: https://gerrit.osmocom.org/c/libosmocore/+/21598/3/src/gb/bssgp_bvc_fsm.c@4 PS3, Line 4: /* FIXME: This should probably be moved to libosmogb? */ it's already inlibosmogb right? https://gerrit.osmocom.org/c/libosmocore/+/21598/3/src/gb/bssgp_bvc_fsm.c@70 PS3, Line 70: uint32_t advertised; not important, but these can really be uint16_t then. https://gerrit.osmocom.org/c/libosmocore/+/21598/3/src/gb/bssgp_bvc_fsm.c@283 PS3, Line 283: osmo_fsm_inst_state_chg(fi, BSSGP_BVCFSM_S_UNBLOCKED, T1_SECS, T1); Not required, but you probably want to move to using osmo_tdef structures and FSM APIs at some point, so that timers are hooked transparently to state changes. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icbe8e4f03b68fd73b8eae95f6f6cccd4fa9af95a Gerrit-Change-Number: 21598 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Tue, 08 Dec 2020 10:58:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
