neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523 )
Change subject: add handover_2G suite, with handover.py test ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523/2/sysmocom/suites/handover_2G/handover.py File sysmocom/suites/handover_2G/handover.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523/2/sysmocom/suites/handover_2G/handover.py@91 PS2, Line 91: with bsc.ctrl() as bsc_ctrl: > BTW, I'd do that ofc inside the obj class, so test doesn't need to care about > those details. […] that's a good alternative, yes. Since my last comment I also considered simply *always* opening a CTRL and VTY connection. In defense of the 'with' statement: the point of 'with' is to un-use an object no matter how that 'with' block is exited, be it an exception or plain being done with it. It is a simplification of the 'try: ... finally:' pattern. 'with' is usually very nice, lean+powerful, imho, but i accept that you prefer less indent in test scripts (though it's a cosmetic that we don't even mention in most code) -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I0b2671304165a1aaae2b386af46fbd8b098e3bd8 Gerrit-Change-Number: 21523 Gerrit-PatchSet: 3 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Tue, 08 Dec 2020 12:53:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
