laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/21561 )

Change subject: gbproxy: use gbprox_relay2peer() whenever possible
......................................................................

gbproxy: use gbprox_relay2peer() whenever possible

gbprox_relay2peer() is a small wrapper around gbprox_relay2nse(),
but as it manages the transmit error counter, we should use it whenever
possible.

Change-Id: I85ab49ca0a25dd7c54b88c4fdc8838843e6d2209
---
M src/gbproxy/gb_proxy.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/gbproxy/gb_proxy.c b/src/gbproxy/gb_proxy.c
index a30f5ad..a90030e 100644
--- a/src/gbproxy/gb_proxy.c
+++ b/src/gbproxy/gb_proxy.c
@@ -519,7 +519,7 @@
                        hash_for_each(nse->bvcs, j, bvc, list) {
                                if (!memcmp(bvc->ra, TLVP_VAL(tp, 
BSSGP_IE_ROUTEING_AREA), 6)) {
                                        LOGPNSE(nse, LOGL_INFO, "routing to NSE 
(RAI match)\n");
-                                       gbprox_relay2nse(msg, nse, ns_bvci);
+                                       gbprox_relay2peer(msg, bvc, ns_bvci);
                                        n_nses++;
                                        /* Only send it once to each NSE */
                                        break;
@@ -533,7 +533,7 @@
                        hash_for_each(nse->bvcs, j, bvc, list) {
                                if (!memcmp(bvc->ra, TLVP_VAL(tp, 
BSSGP_IE_LOCATION_AREA), 5)) {
                                        LOGPNSE(nse, LOGL_INFO, "routing to NSE 
(LAI match)\n");
-                                       gbprox_relay2nse(msg, nse, ns_bvci);
+                                       gbprox_relay2peer(msg, bvc, ns_bvci);
                                        n_nses++;
                                        /* Only send it once to each NSE */
                                        break;
@@ -545,7 +545,7 @@
                hash_for_each(cfg->bss_nses, i, nse, list) {
                        hash_for_each(nse->bvcs, j, bvc, list) {
                                LOGPNSE(nse, LOGL_INFO, "routing to NSE 
(broadcast)\n");
-                               gbprox_relay2nse(msg, nse, ns_bvci);
+                               gbprox_relay2peer(msg, bvc, ns_bvci);
                                n_nses++;
                                /* Only send it once to each NSE */
                                break;

--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21561
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I85ab49ca0a25dd7c54b88c4fdc8838843e6d2209
Gerrit-Change-Number: 21561
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-MessageType: merged

Reply via email to