lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/20397 )
Change subject: sgsn: Use the new NS2 api ...................................................................... Patch Set 13: (4 comments) https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/4//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/4//COMMIT_MSG@7 PS4, Line 7: sgsn: Use the new NS2 api > it would be good to elaborate a bit here. […] Done https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/11/src/sgsn/gprs_gb.c File src/sgsn/gprs_gb.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/11/src/sgsn/gprs_gb.c@117 PS11, Line 117: osmo_prim_init(&nsp.oph, SAP_NS, PRIM_NS_UNIT_DATA, > no line break needed, here and in many other occasions, at least that's my > feeling usually it's than bigger as 80 chars. but I don't mind. https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/11/src/sgsn/gprs_gb.c@143 PS11, Line 143: LOGP(DGPRS, LOGL_NOTICE, > no line break needed (at leat not for four lines), here and in many other > occasions, at least that's […] Ack https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/11/src/sgsn/gprs_gb.c@184 PS11, Line 184: get_value_string(osmo_prim_op_names, oph->operation), > likewise Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20397 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I92a3bcaf166b091a22d74c7c1586964d33d7cc9d Gerrit-Change-Number: 20397 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 16 Dec 2020 22:39:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment
