laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21692 )
Change subject: gbproxy: Add "show gbproxy cell ..." VTY command ...................................................................... Patch Set 8: (1 comment) https://gerrit.osmocom.org/c/osmo-sgsn/+/21692/7/src/gbproxy/gb_proxy_vty.c File src/gbproxy/gb_proxy_vty.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/21692/7/src/gbproxy/gb_proxy_vty.c@251 PS7, Line 251: DEFUN(show_gbproxy_cell, show_gbproxy_cell_cmd, "show gbproxy cell [stats]", > This looks wrong to me: you have 4 words in the command vector, and 5 > docstrings? nice catch. Indeed I was first thinking of adding an additional qualifier like "all" which we can then later exntend with some other qualifier like "bvci ..." or "cell-id ..." But I guess we can do the same without that "all". Will fix. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iad1e8bbc358df9a3b3392404a70445a169dfebd5 Gerrit-Change-Number: 21692 Gerrit-PatchSet: 8 Gerrit-Owner: laforge <[email protected]> Gerrit-Assignee: daniel <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Comment-Date: Fri, 18 Dec 2020 10:42:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
