laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21796 )
Change subject: osmo_e1f.c: sa4..sa8 bits should be all-1 by default ...................................................................... osmo_e1f.c: sa4..sa8 bits should be all-1 by default From ITU-T G.704 Table 5A Note 4: > Bits S a4 to S a8 (where these are not used) should be set to 1 on > links crossing an international border. Change-Id: Id55599a7152a90f85076de810db2a03ac6f3aac1 --- M software/obsolete/osmo_e1f.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/software/obsolete/osmo_e1f.c b/software/obsolete/osmo_e1f.c index 5ea6d54..6a8725c 100644 --- a/software/obsolete/osmo_e1f.c +++ b/software/obsolete/osmo_e1f.c @@ -59,7 +59,7 @@ e1i->crc4_enabled = crc4_enabled; e1i->notify_cb = cb; - e1i->tx.sa4_sa8 = 0x00; + e1i->tx.sa4_sa8 = 0x1f; e1i->priv = priv; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21796 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Id55599a7152a90f85076de810db2a03ac6f3aac1 Gerrit-Change-Number: 21796 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-MessageType: merged