fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21788 )
Change subject: power_control: send default parameters from bootstrap_rsl() ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/21788/2/src/osmo-bsc/osmo_bsc_main.c File src/osmo-bsc/osmo_bsc_main.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21788/2/src/osmo-bsc/osmo_bsc_main.c@344 PS2, Line 344: if (trx->bts->model->power_ctrl_send_def_params != NULL) { > I think a more generic per-model callback function for "do whatever you want > to do when a RSL link c […] I was thinking about that, but after looking at the code I realized that it's not that easy. 'RSL link comes up' is too high level: BTS models by Nokia want something to be sent before System Information, and something after. How do we generalize this? Moreover, I need to be able to trigger re-sending of the default parameters from the VTY, so I find the current approach more flexible. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I46ae4e6003a1839ee57f8e941a54bf479f7e532d Gerrit-Change-Number: 21788 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Sat, 19 Dec 2020 17:07:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment
