laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21272 )
Change subject: osmobsc-usermanual: Add Chapter with AoIP message flow examples ...................................................................... Patch Set 1: (6 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/21272/1/doc/manuals/chapters/aoip-flows.adoc File doc/manuals/chapters/aoip-flows.adoc: https://gerrit.osmocom.org/c/osmo-bsc/+/21272/1/doc/manuals/chapters/aoip-flows.adoc@17 PS1, Line 17: Depending on the MSc implementation, there may be either > ", in between the BSC and the MSC there may be either" Done https://gerrit.osmocom.org/c/osmo-bsc/+/21272/1/doc/manuals/chapters/aoip-flows.adoc@19 PS1, Line 19: * a dedicated STP (or multiple replicated STPs) in front of the STP > "in front of the MSC" (or remove since it's explained above if you change as > I propose) Done https://gerrit.osmocom.org/c/osmo-bsc/+/21272/1/doc/manuals/chapters/aoip-flows.adoc@85 PS1, Line 85: of either RAN nor CN. Either side does not need to know the > s/nor/or/ Done https://gerrit.osmocom.org/c/osmo-bsc/+/21272/1/doc/manuals/chapters/aoip-flows.adoc@86 PS1, Line 86: internal structure of the other side. > , since the RTP endpoint parameters are negotiated/informed over the the A > interface Done https://gerrit.osmocom.org/c/osmo-bsc/+/21272/1/doc/manuals/message-sequences/a_interface_bringup.msc File doc/manuals/message-sequences/a_interface_bringup.msc: https://gerrit.osmocom.org/c/osmo-bsc/+/21272/1/doc/manuals/message-sequences/a_interface_bringup.msc@3 PS1, Line 3: #bsc[label="BSC"], mgwr[label="MGW(RAN)"], stp[label="STP"], _msc[label="MSC"], mgwc[label="MGW(CN)"]; > this can be removed? Done https://gerrit.osmocom.org/c/osmo-bsc/+/21272/1/doc/manuals/message-sequences/mo_call-bsc-msc-mgw-aoip.msc File doc/manuals/message-sequences/mo_call-bsc-msc-mgw-aoip.msc: https://gerrit.osmocom.org/c/osmo-bsc/+/21272/1/doc/manuals/message-sequences/mo_call-bsc-msc-mgw-aoip.msc@30 PS1, Line 30: #bsc -> mgcp [label="MGCP MDCX rtpbridge/2@mgw (optional)"]; > is this commented? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21272 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I001d5f85c95098269b5f129b0c53c3544b96ffb0 Gerrit-Change-Number: 21272 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Sun, 20 Dec 2020 21:16:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
