laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/17876 )

Change subject: SMS-over-GSUP: notify sender if no transaction found
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-msc/+/17876/1/src/libmsc/gsm_04_11_gsup.c
File src/libmsc/gsm_04_11_gsup.c:

https://gerrit.osmocom.org/c/osmo-msc/+/17876/1/src/libmsc/gsm_04_11_gsup.c@164
PS1, Line 164: GMM_CAUSE_NO_PDP_ACTIVATED
> Well, we're using GMM specific cause values (see enum gsm48_gmm_cause) for 
> something that has noting […]
what about that plan t ouse the RP_CAUSE_IE ?



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17876
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4f564610fadbfdbbc33de267786534a5405319f6
Gerrit-Change-Number: 17876
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Comment-Date: Sun, 27 Dec 2020 13:01:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to