laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21735 )
Change subject: SGSN_Tests: test RIM message passing ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21735/2/sgsn/SGSN_Tests.ttcn File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21735/2/sgsn/SGSN_Tests.ttcn@175 PS2, Line 175: port BSSGP_PT RIM[NUM_GB]; > Why not have this into BSSGP_ConnHdlr ? The connHdlr is per TLLI. (of which there can be N:1 per PTP BVC, of which there can be N:1 per NSE). The RIM port exists once per-NSE. So it's really two layers of abstraction away. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21735 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If0ab08dcdc28819740cc07fd4dc1fea47ba10843 Gerrit-Change-Number: 21735 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Tue, 05 Jan 2021 15:38:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
