laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21774 )
Change subject: icE1usb fw: Internal API for configuring E1 rx/tx config register ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21774/3/firmware/ice40-riscv/icE1usb/e1.c File firmware/ice40-riscv/icE1usb/e1.c: https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21774/3/firmware/ice40-riscv/icE1usb/e1.c@277 PS3, Line 277: e1_regs->tx.csr = (e1_regs->tx.csr & ~TXCR_PERMITTED) | g_e1.tx.cr; > No that's not correct, the overflow bit (read only) is the same as the > overflow clear (write only) f […] Ack https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21774/3/firmware/ice40-riscv/icE1usb/e1.c@288 PS3, Line 288: } > Same as TX Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21774 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ib23f9b99f169ab18d730bcf67b97a7b6bf863e98 Gerrit-Change-Number: 21774 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <[email protected]> Gerrit-Comment-Date: Tue, 05 Jan 2021 22:24:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: tnt <[email protected]> Gerrit-MessageType: comment
