laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21715 )
Change subject: icE1usb fw: Expose error conditions from E1 driver ...................................................................... Patch Set 7: (1 comment) > Patch Set 7: Code-Review+1 > > (1 comment) > > Minor typo ? > But otherwise looks good. https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21715/7/firmware/ice40-riscv/icE1usb/ice1usb_proto.h File firmware/ice40-riscv/icE1usb/ice1usb_proto.h: https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21715/7/firmware/ice40-riscv/icE1usb/ice1usb_proto.h@85 PS7, Line 85: ICE1USB_IRQQ_T_ERRCNT = 1, > IRQQ ? Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/21715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Iba3e00a2b28a2fef6dbd986bfc706c1619c3a3ed Gerrit-Change-Number: 21715 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-Comment-Date: Tue, 05 Jan 2021 22:25:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: tnt <[email protected]> Gerrit-MessageType: comment
