pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21949 )
Change subject: gprs_bssgp: abuse gsm48_encode_ra() to encode TAC ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21949/2/src/gb/gprs_bssgp.c File src/gb/gprs_bssgp.c: https://gerrit.osmocom.org/c/libosmocore/+/21949/2/src/gb/gprs_bssgp.c@405 PS2, Line 405: .lac = ri->eutran.tai.tac, /* intentional */ so probably worth it adding "intentional, TAI uses same format as RAI" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I986552aa52cf38b1c5290d2e5cd3ff2d1c36a4e5 Gerrit-Change-Number: 21949 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 07 Jan 2021 13:21:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment