pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22051 )
Change subject: power_control: properly track the first initial state ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/22051/1/src/common/power_control.c File src/common/power_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/22051/1/src/common/power_control.c@81 PS1, Line 81: if (mps->meas_num++ == 0) { a boolean would be better, otherwise you are applying wrong value when it overflows (not critical though since it would take a long time, but still it's easy to fix as mentioned). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22051 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I16e7474b5affbd90855a2e407b305e9dec581dfa Gerrit-Change-Number: 22051 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 08 Jan 2021 13:31:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
