daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22210 )
Change subject: gprs_ns2: implement BLOCK/UNBLOCK of a NSVC by vty ...................................................................... Patch Set 8: Code-Review+1 (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/22210/1/src/gb/gprs_ns2_internal.h File src/gb/gprs_ns2_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/22210/1/src/gb/gprs_ns2_internal.h@314 PS1, Line 314: int ns2_vc_block(struct gprs_ns2_vc *nsvc); > do you need it? if so we can make them public, if not i would prefer to not > export them. I can't think of a concrete example, but my feeling was we want to NS-Block from within osmo-gbproxy under certain conditions. Maybe I mixed that up with BVC-(Un)Block, let's keep it private for now. https://gerrit.osmocom.org/c/libosmocore/+/22210/1/src/gb/gprs_ns2_vc_fsm.c File src/gb/gprs_ns2_vc_fsm.c: https://gerrit.osmocom.org/c/libosmocore/+/22210/1/src/gb/gprs_ns2_vc_fsm.c@120 PS1, Line 120: GPRS_NS2_EV_OM_UNBLOCK, /* vty cmd: unblock*/ > sound great. i'll only add them as REQ and do a second patch to rename the > other. Done https://gerrit.osmocom.org/c/libosmocore/+/22210/1/src/gb/gprs_ns2_vty2.c File src/gb/gprs_ns2_vty2.c: https://gerrit.osmocom.org/c/libosmocore/+/22210/1/src/gb/gprs_ns2_vty2.c@1519 PS1, Line 1519: vty_out(vty, "Could not find NSVCI %u%s", id, VTY_NEWLINE); %05u -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic0ce3c5fabc8644cc1ee71a8f6dd783fadf7b84d Gerrit-Change-Number: 22210 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Assignee: daniel <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 18 Jan 2021 11:44:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: daniel <[email protected]> Comment-In-Reply-To: lynxis lazus <[email protected]> Gerrit-MessageType: comment
