daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21400 )
Change subject: gprs_ns2: Give NS-VC FSMs a proper name/identifier ...................................................................... Patch Set 5: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21400/3/src/gb/gprs_ns2_udp.c File src/gb/gprs_ns2_udp.c: https://gerrit.osmocom.org/c/libosmocore/+/21400/3/src/gb/gprs_ns2_udp.c@384 PS3, Line 384: nse->nsei, "FIXME" /*osmo_sockaddr_to_str(remote)*/); > This patch is not longer WIP but the FIXME is still there :) […] I don't see the fixme in patchset 5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9d5b0684584d03685900c6298fe70246793de14 Gerrit-Change-Number: 21400 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Mon, 18 Jan 2021 11:52:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
