laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22046 )
Change subject: gprs_bssgp: add utilities to send and parse BSSGP rim PDUs ...................................................................... Patch Set 8: (2 comments) sorry, two more minor issues. But then it's all good. https://gerrit.osmocom.org/c/libosmocore/+/22046/8/src/gb/gprs_bssgp_util.c File src/gb/gprs_bssgp_util.c: https://gerrit.osmocom.org/c/libosmocore/+/22046/8/src/gb/gprs_bssgp_util.c@709 PS8, Line 709: LOGP(DLBSSGP, LOGL_DEBUG, "BSSGP RIM (NSEI=%u) unable to parse RIM container.\n", nsei); I understand that the "default" clause above has "return 0", as per the comment above the switch statement. But this clause is about an actual error code returned from one of the parser functions for the supported IEs. Shouldn't this be logged as NOTICE/ERROR and return rc instead of 0? https://gerrit.osmocom.org/c/libosmocore/+/22046/8/src/gb/gprs_bssgp_util.c@725 PS8, Line 725: check for !msg and return NULL. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I18134fd9938040d2facb6beee3732628b167ce8c Gerrit-Change-Number: 22046 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 19 Jan 2021 16:45:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
