fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21862 )
Change subject: bssgp_rim: add encoder/decoder for NACC related RIM containers ...................................................................... Patch Set 13: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/21862/13/src/gb/gprs_bssgp_rim.c File src/gb/gprs_bssgp_rim.c: https://gerrit.osmocom.org/c/libosmocore/+/21862/13/src/gb/gprs_bssgp_rim.c@343 PS13, Line 343: buf_ptr[1] = len & 0xff; Something is definitely wrong here: you store (x >> 8) and then overwrite it by (x & 0xff). I guess the second part should go to buf_ptr[2]? See CID#216670. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibbc7fd67658e3040c12abb5706fe9d1f31894352 Gerrit-Change-Number: 21862 Gerrit-PatchSet: 13 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Wed, 20 Jan 2021 09:26:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
