laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22343 )
Change subject: gprs_ns2: inform the NS user (BSSGP) about the MTU of a NSE ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/22343/2/src/gb/gprs_ns2_udp.c File src/gb/gprs_ns2_udp.c: https://gerrit.osmocom.org/c/libosmocore/+/22343/2/src/gb/gprs_ns2_udp.c@121 PS2, Line 121: int > In that case do we really have to pass the MTU though a status primitive or > could we just have hard- […] I don't really have a preference either way. I think for the SGSN it is useful to be able to determine it _somehow_, so it can use it for the related SNDCP/LLC XID to ensure no "un-transport-able" NS frames. I don't expect it to change at runtime, unless somebody would switch from FR to IP transport (or vice-versa) at runtime, which is probably the most unlikely of all events ;) The other part where the MTU is needed to be known is inside the NS2 code when generating NS-STATUS, as the inner PDU may need to be truncated. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5016b295db6185ec131d83089cf6c806e34ef1b6 Gerrit-Change-Number: 22343 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Comment-Date: Thu, 21 Jan 2021 09:32:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: daniel <[email protected]> Gerrit-MessageType: comment
