dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22385 )
Change subject: Introduce NACC support ...................................................................... Patch Set 2: Code-Review-1 (3 comments) I found a few things: https://gerrit.osmocom.org/c/osmo-pcu/+/22385/2/src/gprs_bssgp_rim.c File src/gprs_bssgp_rim.c: https://gerrit.osmocom.org/c/osmo-pcu/+/22385/2/src/gprs_bssgp_rim.c@118 PS2, Line 118: return bssgp_tx_status(BSSGP_CAUSE_UNKN_RIM_AI, NULL, msg); I believe this is wrong. This flag indicates an application error, there is nothing wrong with the routing or so. When I get 3GPP TS 48.018 8c.2.4.3 right, than there is nothing much you cen do other than ending the procedure. https://gerrit.osmocom.org/c/osmo-pcu/+/22385/2/src/nacc_fsm.c File src/nacc_fsm.c: https://gerrit.osmocom.org/c/osmo-pcu/+/22385/2/src/nacc_fsm.c@202 PS2, Line 202: .raid = { /* TODO: fill properly */ What exactly is not properly filled? https://gerrit.osmocom.org/c/osmo-pcu/+/22385/2/src/nacc_fsm.c@220 PS2, Line 220: .pdu_type_ext = 1, There is an enum bssgp_rim_pdu_type for pdu_type_ext in gsm_08_18.h. (use RIM_PDU_TYPE_SING_REP) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id35f40d05f3e081f32fddbf1fa34cb338db452ca Gerrit-Change-Number: 22385 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Comment-Date: Fri, 22 Jan 2021 18:23:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
