laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21935 )
Change subject: l1sap: include Uplink RSSI and C/I in GSMTAP packets ...................................................................... Patch Set 2: > Patch Set 2: > > I don't know what to do here, osmo-trx can't really measure the rssi because > even though uhd exposes it as a sensor and reading it takes multiple > timeslots so it's useless, while snr was never really properly specified, is > it rssi of used ts vs rssi of unused ts? is it supposed to be c/i? The proprietary PHY backends of osmo-bts (sysmo, lc15, oc2g at least) expose C/I. And IIRC, C/I is laso computed by osmo-bts-trx on a per-burst basis, as we use it for rate adaptation in osmo-pcu. I think the main concern here is whether or not we should abuse a GSMTAP field specified and named for RSSI and now fill it with something else (C/I). I'm not fundamentally opposed, I'm just saying it's incorrect... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21935 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic48283fa76b682aee151a94ef7274ac96545e087 Gerrit-Change-Number: 21935 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Fri, 22 Jan 2021 20:46:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
