dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22368 )
Change subject: gprs_bssgp_rim: add serving BSS NACC application ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/22368/2/src/gprs_bssgp_rim.c File src/gprs_bssgp_rim.c: https://gerrit.osmocom.org/c/osmo-pcu/+/22368/2/src/gprs_bssgp_rim.c@208 PS2, Line 208: BSSGP RIM (NSEI=%u) > we just had this in the review of another patch; please introduce and use > something like #define LOG […] Done https://gerrit.osmocom.org/c/osmo-pcu/+/22368/2/src/pcu_l1_if.cpp File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/22368/2/src/pcu_l1_if.cpp@660 PS2, Line 660: LOGP(DL1IF, LOGL_DEBUG, " si1=%s\n", osmo_hexdump_nospc(info_ind->si1, GSM_MACBLOCK_LEN)); > better use sizeof(info_ind->si1) everywhere, we don't really car about the > real size here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22368 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id72118120c14984d2fb1b918b41fac4868150d41 Gerrit-Change-Number: 22368 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Wed, 27 Jan 2021 15:07:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
