fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 )
Change subject: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si ...................................................................... Patch Set 5: (1 comment) It seems I am the only one who is still against this approach... The proposed encoding is kind of problematic, especially if one would need to add more fields to INFO.ind. And it's still not clear what is the plan for a situation when we would need to send additional SI messages to the PCU, e.g. SI4. Again, why not to introduce a separate PCUIF message type for SI? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/4/library/PCUIF_Types.ttcn File library/PCUIF_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/4/library/PCUIF_Types.ttcn@224 PS4, Line 224: OCT23 si1 optional, This encoding is ambiguous. Imagine that one of the SI kinds is not present for some reason, let's say SI3 is missing. This is possible because those are separate messages on the A-bis/RSL, and the BTS would re-send INFO.ind for each of them. How would you guess on the receive side what is what and where? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9054ab0e969c0fbfdc671c92d44cc61360959adc Gerrit-Change-Number: 22369 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Thu, 28 Jan 2021 21:37:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
