laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/22385 )
Change subject: Introduce NACC support ...................................................................... Patch Set 11: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/22385/11/src/nacc_fsm.c File src/nacc_fsm.c: https://gerrit.osmocom.org/c/osmo-pcu/+/22385/11/src/nacc_fsm.c@633 PS11, Line 633: connect to CTRL > I am afraid this message may be confusing for the end user, because usually > our osmo-apps are CTRL s […] Ack https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.h File src/neigh_cache.h: https://gerrit.osmocom.org/c/osmo-pcu/+/22385/9/src/neigh_cache.h@49 PS9, Line 49: struct llist_head list; /* to be included in neigh_cache->list */ > I would then need to hash quite complex keys, I'll have a look but I think > I'll leave it as it is. […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id35f40d05f3e081f32fddbf1fa34cb338db452ca Gerrit-Change-Number: 22385 Gerrit-PatchSet: 11 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Fri, 29 Jan 2021 09:51:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
