laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/22510 )
Change subject: lchan assignment when RTP is set up: don't break on Mode Modify ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/22510/1/src/osmo-bsc/assignment_fsm.c File src/osmo-bsc/assignment_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/22510/1/src/osmo-bsc/assignment_fsm.c@442 PS1, Line 442: && !conn->lchan->fi_rtp) { > i like it when completely unrelated conditions are on a separate line well, but it definitely is not how we generally write code in osmocom. But not a blocker. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/22510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I06d3f35fcc71d77e1f30c2b15ab221ef7d5f7f27 Gerrit-Change-Number: 22510 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 29 Jan 2021 21:19:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
