fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 )
Change subject: PCU_Tests: add testcase TC_rim_ran_info_req_single_rep and _no_si ...................................................................... Patch Set 6: (1 comment) > Patch Set 6: > > I hope I have found a better way now to transfer the sysinfo to the PCU. > Actually there is a SAPI 4 in the PCUIF protocol through which we already > send SI13. This can be extended to transfer SI1 and SI3 as well. Nice! Would be funny it we discovered this after merging your initial approach ;) If you remove the first (redundant?) octet in DATA.ind messages, there would be no need to bump PCUIF version at all. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/6/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369/6/pcu/PCU_Tests.ttcn@3589 PS6, Line 3589: '01'O What is the purpose of this octet? I guess to indicate the type of SI? We don't need it because it's contained in the first octet of the SI itself: '55'O - SI1, '49'O - SI3, '01'O - SI13. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9054ab0e969c0fbfdc671c92d44cc61360959adc Gerrit-Change-Number: 22369 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Sat, 30 Jan 2021 01:09:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
