lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22575 )
Change subject: frame_relay: Add status call-backs for link + DLC status changes ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/22575/2/src/gb/frame_relay.c File src/gb/frame_relay.c: https://gerrit.osmocom.org/c/libosmocore/+/22575/2/src/gb/frame_relay.c@a421 PS2, Line 421: return I'm not as 100 % sure here. I would still say we have to follow the Network on the DLCs which are valid or not. As long our link is invalid it doesn't matter. https://gerrit.osmocom.org/c/libosmocore/+/22575/2/src/gb/frame_relay.c@a437 PS2, Line 437: return; we can't remove this. Otherwise the link recovery would set all User Equipment configured DLCs active. But only the network can say which DLCs are active. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iec19db4e48642c3fcb0aa11fa7787b8323fd0e5a Gerrit-Change-Number: 22575 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Comment-Date: Mon, 01 Feb 2021 02:01:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
