laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22575 )
Change subject: frame_relay: Add status call-backs for link + DLC status changes ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/22575/2/src/gb/frame_relay.c File src/gb/frame_relay.c: https://gerrit.osmocom.org/c/libosmocore/+/22575/2/src/gb/frame_relay.c@a421 PS2, Line 421: return > I'm not as 100 % sure here. […] if the link has failed, I would argue that by definition you have lost all DLCs. Otherwise you would loose the link but the local applications still think the DLCs are active. Marking the DLCs as inactive (and notifying them) will make the application aware... https://gerrit.osmocom.org/c/libosmocore/+/22575/2/src/gb/frame_relay.c@a437 PS2, Line 437: return; > we can't remove this. […] Ack -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iec19db4e48642c3fcb0aa11fa7787b8323fd0e5a Gerrit-Change-Number: 22575 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Comment-Date: Mon, 01 Feb 2021 08:37:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lyn...@fe80.eu> Gerrit-MessageType: comment
