laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/22732 )
Change subject: apn_start: avoid segfault if missing tun-device ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-ggsn/+/22732/2/ggsn/ggsn_vty.c File ggsn/ggsn_vty.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/22732/2/ggsn/ggsn_vty.c@710 PS2, Line 710: apn->cfg.shutdown = false; > this shutdown var is really confusing lol that's how cisco works: You have all new nodes (e.g. vlans, bridges, ...) created in VTY by default in "shutdown" mode, and they need explicit enabling via "no shutdown". -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/22732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I9f71af65cc0eed71728c04b774e5c08352947913 Gerrit-Change-Number: 22732 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Fri, 05 Feb 2021 20:47:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
