fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22763 )
Change subject: oml: reuse the given msgb in oml_fom_ack_nack() ...................................................................... Patch Set 2: > Patch Set 2: > > I'm still not convinced why this is a good idea. How many of those ACK/NACKs > do we need to send per second in order to be optimizing it? Why can > additional IEs not be added toa copy? I agree that we don't urgently need this optimization, since OML link is quite silent compared to RSL, and the msgb_copy() approach should also work for the patch on top of it (I5c73e83daad0cea07b9cb674c393e0bfc6268a61). On the other hand, I don't see a reason not to merge this change. We already implement this approach (do-not-free indication) in other places, and doing msgb_copy() whilst it could have been avoided looks sub-optimal to me. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22763 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I17f61636e9a144017e2c46b1540d152c21529391 Gerrit-Change-Number: 22763 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Tue, 09 Feb 2021 17:50:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
