daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22343 )
Change subject: gprs_ns2: inform the NS user (BSSGP) about the MTU of a NSE ...................................................................... Patch Set 6: (4 comments) https://gerrit.osmocom.org/c/libosmocore/+/22343/6//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/22343/6//COMMIT_MSG@9 PS6, Line 9: The BSSGP need to know the MTU of the BSSGP layer. The BSSGP layer needs to know [...] https://gerrit.osmocom.org/c/libosmocore/+/22343/6//COMMIT_MSG@12 PS6, Line 12: contain contains https://gerrit.osmocom.org/c/libosmocore/+/22343/6/include/osmocom/gprs/gprs_ns2.h File include/osmocom/gprs/gprs_ns2.h: https://gerrit.osmocom.org/c/libosmocore/+/22343/6/include/osmocom/gprs/gprs_ns2.h@138 PS6, Line 138: BSSGP PDU >From NS view it's probably "more correct" to talk about NS SDU https://gerrit.osmocom.org/c/libosmocore/+/22343/6/src/gb/gprs_ns2_fr.c File src/gb/gprs_ns2_fr.c: https://gerrit.osmocom.org/c/libosmocore/+/22343/6/src/gb/gprs_ns2_fr.c@804 PS6, Line 804: bind->nsi = nsi; Unrelated change? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5016b295db6185ec131d83089cf6c806e34ef1b6 Gerrit-Change-Number: 22343 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Comment-Date: Fri, 12 Feb 2021 02:25:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
