fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/10808 )
Change subject: GSMTAP: make remote host for Um logging configurable via VTY ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/10808/3/src/common/vty.c File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/10808/3/src/common/vty.c@1834 PS3, Line 1834: cfg_bts_gsmtap_remote_host_cmd > should use DEFUN_ATTR now to indicate that it only becomes active at program > restart. The current [implicit] policy is that all commands require full program restart unless stated otherwise. This is a safe default assumption, so we don't need a special attribute for that (otherwise basically all DEFUN statements would need to be changed to DEFUN_ATTR in all programs). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/10808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I17676a21c4e0c9cbc88f2c5c53a39c6c6c473ca1 Gerrit-Change-Number: 10808 Gerrit-PatchSet: 3 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Mon, 15 Feb 2021 15:06:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
