dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/22888 )
Change subject: l1sap: add logging and VTY introspection for ACCH repetition ...................................................................... Patch Set 2: (5 comments) (gerrit) https://gerrit.osmocom.org/c/osmo-bts/+/22888/1/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/22888/1/src/common/l1sap.c@938 PS1, Line 938: DL1C > Pau was complaining about unreadable DL1C (https://osmocom.org/issues/5007), > maybe DL1P? […] Done https://gerrit.osmocom.org/c/osmo-bts/+/22888/1/src/common/l1sap.c@938 PS1, Line 938: DL-FACCH repetition: repeating FACCH channel > How can you 'repeat FACCH channel'? You actually repeat a 'FACCH block', or > more precisely 'retransm […] Done https://gerrit.osmocom.org/c/osmo-bts/+/22888/1/src/common/l1sap.c@943 PS1, Line 943: channel > Same here. Done https://gerrit.osmocom.org/c/osmo-bts/+/22888/1/src/common/l1sap.c@1091 PS1, Line 1091: > ws, unrelated Done https://gerrit.osmocom.org/c/osmo-bts/+/22888/1/src/common/l1sap.c@1468 PS1, Line 1468: LOGPLCHAN(lchan, DL1C, LOGL_DEBUG, "UL-SACCH repetition: disabled by BSC\n"); > Same here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/22888 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I59d11fd03be3d29fb8a4279d9945b03006764c0e Gerrit-Change-Number: 22888 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 16 Feb 2021 14:16:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
