lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22872 )
Change subject: gprs_ns2: rework IP-SNS binds ...................................................................... Patch Set 10: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/22872/8/src/gb/gprs_ns2_sns.c File src/gb/gprs_ns2_sns.c: https://gerrit.osmocom.org/c/libosmocore/+/22872/8/src/gb/gprs_ns2_sns.c@100 PS8, Line 100: { GPRS_SNS_EV_REQ_ADD_BIND, "ADD_BIND"}, > wrong indentation? Done https://gerrit.osmocom.org/c/libosmocore/+/22872/8/src/gb/gprs_ns2_sns.c@125 PS8, Line 125: struct ns2_sns_bind *current_bind; > I wonder, if there's only 1 current bind, why do we need a list entry and not > simply a pointer to th […] it's similiar to the *initial, but it's a bind instead of an endpoint. i'll renmae initial_bind -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22872 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9ab8092bf286e7d90e92f5702a5404425e959c84 Gerrit-Change-Number: 22872 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 16 Feb 2021 16:27:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
