Change in osmo-pcu[master]: gprs_bssgp: rename gprs_ns_config -> gprs_ns_update_config

[laforge]

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/22931 )

Change subject: gprs_bssgp: rename gprs_ns_config -> gprs_ns_update_config
......................................................................

gprs_bssgp: rename gprs_ns_config -> gprs_ns_update_config

Improve the naming of the function to match it's purpose.

Related: SYS#5354
Change-Id: Ib8e4ae734503fd6f6695d9d6767d809e1bf79d22
---
M src/gprs_bssgp_pcu.c
M src/gprs_bssgp_pcu.h
M src/pcu_l1_if.cpp
M tests/emu/pcu_emu.cpp
4 files changed, 8 insertions(+), 7 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/gprs_bssgp_pcu.c b/src/gprs_bssgp_pcu.c
index 7d793be..ce36c6b 100644
--- a/src/gprs_bssgp_pcu.c
+++ b/src/gprs_bssgp_pcu.c
@@ -1097,10 +1097,11 @@
        return 0;
 }

-int gprs_ns_config(struct gprs_rlcmac_bts *bts, uint16_t nsei,
-                  const struct osmo_sockaddr *local,
-                  const struct osmo_sockaddr *remote,
-                  uint16_t *nsvci, uint16_t valid)
+/* update the ns configuration if needed */
+int gprs_ns_update_config(struct gprs_rlcmac_bts *bts, uint16_t nsei,
+                         const struct osmo_sockaddr *local,
+                         const struct osmo_sockaddr *remote,
+                         uint16_t *nsvci, uint16_t valid)
 {
        int rc = 0;
        if (!bts->nse) {
diff --git a/src/gprs_bssgp_pcu.h b/src/gprs_bssgp_pcu.h
index 4b0e0aa..db77cbb 100644
--- a/src/gprs_bssgp_pcu.h
+++ b/src/gprs_bssgp_pcu.h
@@ -90,7 +90,7 @@
                uint16_t mcc, uint16_t mnc, bool mnc_3_digits,
                uint16_t lac, uint16_t rac, uint16_t cell_id);

-int gprs_ns_config(struct gprs_rlcmac_bts *bts, uint16_t nsei,
+int gprs_ns_update_config(struct gprs_rlcmac_bts *bts, uint16_t nsei,
                   const struct osmo_sockaddr *local,
                   const struct osmo_sockaddr *remote,
                   uint16_t *nsvci, uint16_t valid);
diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index 9873469..b6d6786 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -583,7 +583,7 @@
                return -EINVAL;
        }

-       return gprs_ns_config(bts, info_ind->nsei, local, remote, nsvci, valid);
+       return gprs_ns_update_config(bts, info_ind->nsei, local, remote, nsvci, 
valid);
 }

 static int pcu_rx_info_ind(struct gprs_rlcmac_bts *bts, const struct 
gsm_pcu_if_info_ind *info_ind)
diff --git a/tests/emu/pcu_emu.cpp b/tests/emu/pcu_emu.cpp
index ef573a7..082f8ea 100644
--- a/tests/emu/pcu_emu.cpp
+++ b/tests/emu/pcu_emu.cpp
@@ -108,7 +108,7 @@
        remote.u.sin.sin_port = htons(sgsn_port);

        pcu = gprs_bssgp_init(bts, 20, 20, 901, 99, false, 1, 0, 0);
-       gprs_ns_config(bts, nsei, &local, &remote, &nsvci, 1);
+       gprs_ns_update_config(bts, nsei, &local, &remote, &nsvci, 1);

        pcu->on_unblock_ack = bvci_unblocked;
        pcu->on_dl_unit_data = bssgp_data;

--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/22931
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ib8e4ae734503fd6f6695d9d6767d809e1bf79d22
Gerrit-Change-Number: 22931
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged