pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22962 )
Change subject: Drop use of log_set_print_filename() API inside libosmocore ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/22962/1/tests/gb/gprs_ns_test.c File tests/gb/gprs_ns_test.c: https://gerrit.osmocom.org/c/libosmocore/+/22962/1/tests/gb/gprs_ns_test.c@911 PS1, Line 911: osmo_signal_register_handler(SS_L_NS, &test_signal, NULL); > why moving this line? Because that way we have all the logging initializers together. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22962 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifc78e1dcba5baf0b41f6ccbbbd1e3f06552d73da Gerrit-Change-Number: 22962 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Comment-Date: Fri, 19 Feb 2021 13:28:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
