On 31 March 2011 20:49, dinkypumpkin <[email protected]> wrote: > > On 31 Mar 2011, at 20:44, Shevek wrote: > >> On 31 March 2011 20:33, Roger Burton West <[email protected]> wrote: >>> On Thu, Mar 31, 2011 at 08:22:26PM +0100, Shevek wrote: >>>> What am I doing wrong? >>> >>> Easiest option (though it's vulnerable to shellmetas showing up in >>> filenames) is probably to do it all in one string: set $cmd instead of >>> @cmd and system($cmd). >>> >> >> OK, this is what I came up with and it works: >> >> @cmd = ( >> $bin->{ffmpeg} . ' -i "' . $file_tmp . '" -vn -acodec copy -f adts - >> | ' . $bin->{ffmpeg} . ' -i - -vn -acodec copy -absf aac_adtstoasc -y >> "' . $prog->{filepart} . '"', >> ); >> >> does anyone have any objections to this? > > Path to ffmpeg exe might have spaces, so should be quoted as well. >
good spot... it's odd, because up till now none of the paths have been quoted, but it has always worked, even with paths with spaces in - is this because of the system() call which I am now changing? _______________________________________________ get_iplayer mailing list [email protected] http://lists.infradead.org/mailman/listinfo/get_iplayer
