1. a-c) is ok now. Thanks for the quick response.
d) For getfem++ to compile with "--disable-superlu" and the superlu folder
removed, the attached patch "disable_superlu.patch" is necessary (Please
don't merge the patch as is. The removal of "superlu/Makefile" from
AC_CONFIG_FILES in configure.in has to depend on the "--disable-superlu"
option).
Additionally the "getfem_superlu.patch" is needed, otherwise installed
headers of superlu cannot be found. I believe the "../" prefix in the
include directives wasn't really necessary.
2.-4. is ok in r3056. Thanks
6. A new issue. r3056 fails to compile with gcc 4.4. The patch
"gmm_inoutput.patch" workarounds the issue by an explicit variable
recasting. A real solution would be to change both "writeHB_mat_double"
arguments "Valfmt" and "Rhsfmt" from "const char*" to "char*", since "const
char*" declaration is a promise not to change the variable value, which is
not held. Anyway I don't know what could get broken by such an interface
change.
Regards
Kostas
On Tue, Aug 18, 2009 at 1:49 PM, Renard Yves <[email protected]>wrote:
>
> Dear Kostas,
>
> Thank you for your important work !
>
> 1) I made some modifications on the license of most of the files listed by
> you, except for superlu files (r3056). I agree with Luis. Superlu could be
> an external dependence for the package.
>
> 4) The problem is fixed.
>
> 5) Name without ++ are ok.
>
> Regards,
>
> Yves.
>
>
> Luis Saavedra <[email protected]> a écrit :
>
> Hi Kostas,
>>
>> thanks for your work!!!
>>
>> 1) The folder superlu can be removed, and reemplaced:
>>
>> * In debian: with package libsuperlu3 (or libsuperlu3-dev for
>> build-package).
>> * In the rest: with
>> http://crd.lbl.gov/~xiaoye/SuperLU/superlu_4.0.tar.gz<http://crd.lbl.gov/%7Exiaoye/SuperLU/superlu_4.0.tar.gz>
>>
>> I think it would be a good idea create a branch dedicated to this issue.
>>
>> 2-3) in r3055, is this ok?
>>
>> 5) libgetfem, python-getfem, but getfem4 don't exist yet.
>>
>> Regards,
>> Luis
>>
>> Konstantinos Poulios escribió:
>>
>>> Hi all,
>>>
>>> The following bug report exists in Debian archive about the packaging
>>> of getfem++:
>>>
>>> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=453065
>>>
>>> The current work in Debian can be found here:
>>>
>>> http://svn.debian.org/wsvn/pkg-kde/krap/getfem%2B%2B/#_krap_getfem++_
>>> http://svn.debian.org/wsvn/pkg-kde/krap/getfem/#_krap_getfem_
>>>
>>> I've opened the following bug report in order to ask for the inclusion
>>> of getfem++ in Ubuntu:
>>>
>>> https://launchpad.net/bugs/413165
>>>
>>> My current work on debianization of getfem++, including experimental
>>> packages for ubuntu jaunty and karmic, can be found here:
>>>
>>> https://launchpad.net/~logari81/+archive/ppa<https://launchpad.net/%7Elogari81/+archive/ppa>
>>> <https://launchpad.net/%7Elogari81/+archive/ppa>
>>>
>>> During the packaging process, several issues came up:
>>>
>>> 1. Licensing. In the attached file "getfem_license_exceptions" I ve
>>> listed all licenses which differ from "LGPL 2.1 or later".
>>> a) In the "tests-2.0", "tests", "internal_tools", "interface",
>>> "contrib", "doc" and "superlu" folders, there are many source files
>>> missing any license and copyright information.
>>> b) Source files referring to "LGPL", "LGPL with incorrect FSF
>>> address" and "LGPL (v2.1 or later) with missing copyright
>>> information", can be found in "internal_tools", "interface" and
>>> "contrib" folders. Probably most of the LGPL'ed files can be
>>> relicensed to "LGPL 2.1 or later" since their authors are using this
>>> LGPL version elsewhere.
>>> c) In the "src" folder, there are double licensed gmm files, but this
>>> is no problem for the packaging. One problem is the missing time
>>> period specification for the contribution of Thorsten Ottosen.
>>> d) Apparently, "superlu" belongs mostly to Xerox. I suppose that the
>>> rest of the files in this folder missing a license declaration are
>>> probably Xerox's contribution. Please complete the missing license
>>> information.
>>>
>>> 2. The "configure" script generated with autoconf 2.64 is broken, as a
>>> workaround, a blank line in "m4/ac_python_devel.m4" has been added
>>> (see patch "ac_python_devel.patch"). Further investigation would be
>>> necessary (probably an autoconf bug).
>>>
>>> 3. Using automake 1.11 installation with "make install" is broken. The
>>> double entry for "check_all.sh" in
>>> "interface/tests/matlab/Makefile.am" has been removed to fix the
>>> problem (see patch tests_matlab_makefile.patch)
>>>
>>> 4. "autogen.sh" spooks many annoying warnings about "AC_CACHE_VAL"
>>> (see the following build log
>>>
>>> http://launchpadlibrarian.net/30384527/buildlog_ubuntu-karmic-i386.getfem%2B%2B_4.0~svn3053-0ubuntu0ppak9_FULLYBUILT.txt.gz<http://launchpadlibrarian.net/30384527/buildlog_ubuntu-karmic-i386.getfem%2B%2B_4.0%7Esvn3053-0ubuntu0ppak9_FULLYBUILT.txt.gz>
>>> <
>>> http://launchpadlibrarian.net/30384527/buildlog_ubuntu-karmic-i386.getfem%2B%2B_4.0%7Esvn3053-0ubuntu0ppak9_FULLYBUILT.txt.gz
>>> >).
>>>
>>> 5. Names of the packages. I 've used the root "getfem" without "++" to
>>> name the various packages in order to comply with the so-name of the
>>> main library. I suppose this can be further discussed in debian and/or
>>> ubuntu when the packages are considered to be accepted. Any remarks on
>>> my choice are always welcome. (A bad example is the gmm standalone
>>> package which in Debian is called libgmm++-dev whether in Ubuntu it is
>>> named libgmm-dev).
>>>
>>> It would be very helpful to solve the issues 1-4 here in upstream
>>> rather than in the packaging. It would also be nice to synchronize with
>>> http://svn.debian.org/wsvn/pkg-kde/krap/getfem%2B%2B/#_krap_getfem++_
>>> I hope my work can be somehow useful for Debian also.
>>>
>>> Regarding the functionality of the packages, up to now, I have only
>>> tested the python interface, which seems to work fine. Any help with
>>> testing the rest (i.e. the -dev packages) is welcome.
>>>
>>> Regards
>>>
>>> Kostas
>>> ------------------------------------------------------------------------
>>>
>>> _______________________________________________
>>> Getfem-users mailing list
>>> [email protected]
>>> https://mail.gna.org/listinfo/getfem-users
>>>
>>
>>
>> _______________________________________________
>> Getfem-users mailing list
>> [email protected]
>> https://mail.gna.org/listinfo/getfem-users
>>
>>
>
>
>
--- getfem++-4.0~svn3056.orig/configure.in
+++ getfem++-4.0~svn3056/configure.in
@@ -361,7 +361,9 @@
[AC_MSG_ERROR([SuperLU library not found])])
AC_CHECK_HEADERS(
- [superlu/colamd.h superlu/slu_Cnames.h superlu/slu_*defs.h superlu/slu_*complex.h],
+ [superlu/colamd.h superlu/slu_Cnames.h \
+ superlu/slu_cdefs.h superlu/slu_ddefs.h superlu/slu_sdefs.h superlu/slu_zdefs.h \
+ superlu/slu_dcomplex.h superlu/slu_scomplex.h],
[usesuperlu="yes"],
[
if test "x$usesuperlu" = "xyes"; then
@@ -752,7 +754,6 @@
Makefile \
m4/Makefile \
cubature/Makefile \
- superlu/Makefile \
src/Makefile \
tests/Makefile \
tests/meshes/Makefile \
--- getfem++-4.0~svn3056.orig/src/getfem_superlu.cc
+++ getfem++-4.0~svn3056/src/getfem_superlu.cc
@@ -31,21 +31,21 @@
# undef FALSE
#endif
-#include "../superlu/slu_Cnames.h"
-#include "../superlu/supermatrix.h"
-#include "../superlu/slu_util.h"
+#include "superlu/slu_Cnames.h"
+#include "superlu/supermatrix.h"
+#include "superlu/slu_util.h"
namespace SuperLU_S {
-#include "../superlu/slu_sdefs.h"
+#include "superlu/slu_sdefs.h"
}
namespace SuperLU_D {
-#include "../superlu/slu_ddefs.h"
+#include "superlu/slu_ddefs.h"
}
namespace SuperLU_C {
-#include "../superlu/slu_cdefs.h"
+#include "superlu/slu_cdefs.h"
}
namespace SuperLU_Z {
-#include "../superlu/slu_zdefs.h"
+#include "superlu/slu_zdefs.h"
}
--- getfem++-4.0~svn3056.orig/src/gmm/gmm_inoutput.h
+++ getfem++-4.0~svn3056/src/gmm/gmm_inoutput.h
@@ -381,6 +381,7 @@
int Valperline, Valwidth, Valprec;
int Valflag; /* Indicates 'E','D', or 'F' float format */
char pformat[16],iformat[16],vformat[19],rformat[19];
+ char *pValflag, *pRhsflag;
gmm::standard_locale sl;
if ( Type[0] == 'C' )
@@ -408,7 +409,10 @@
if ( Type[0] != 'P' ) { /* Skip if pattern only */
if ( Valfmt == NULL ) Valfmt = "(4E21.13)";
ParseRfmt(Valfmt, &Valperline, &Valwidth, &Valprec, &Valflag);
- if (Valflag == 'D') *strchr(Valfmt,'D') = 'E';
+ if (Valflag == 'D') {
+ pValflag = (char *) strchr(Valfmt,'D');
+ *pValflag = 'E';
+ }
if (Valflag == 'F')
SECURE_SPRINTF2(vformat, sizeof(vformat), "%% %d.%df", Valwidth,
Valprec);
@@ -426,7 +430,10 @@
SECURE_SPRINTF2(rformat,sizeof(rformat), "%% %d.%df",Rhswidth,Rhsprec);
else
SECURE_SPRINTF2(rformat,sizeof(rformat), "%% %d.%dE",Rhswidth,Rhsprec);
- if (Rhsflag == 'D') *strchr(Rhsfmt,'D') = 'E';
+ if (Valflag == 'D') {
+ pRhsflag = (char *) strchr(Rhsfmt,'D');
+ *pRhsflag = 'E';
+ }
rhscrd = nrhsentries/Rhsperline;
if ( nrhsentries%Rhsperline != 0) rhscrd++;
if ( Rhstype[1] == 'G' ) rhscrd+=rhscrd;
_______________________________________________
Getfem-users mailing list
[email protected]
https://mail.gna.org/listinfo/getfem-users
