I sent this a while ago and just noticed it never actually made it to the list! So trying again now from my google e-mail...
Begin forwarded message: > From: David Glick <[EMAIL PROTECTED]> > Date: October 17, 2008 4:19:12 PM PDT > To: [email protected] > Subject: roadmap for improvements to GetPaid - PloneFormGen > integration > > Hello all. > > I've been checking out getpaid.formgen to see if it will handle our > common use case of creating a one-shot donation form. This codebase > is a good start at integrating PloneFormGen and GetPaid, so many > thanks to those who have worked on it so far. However, I've > identified a number of places where we'd like to see some > improvement, which I'll list below. We will likely be prioritizing > these and putting some development time into some of them, but I > thought I'd get this discussion going in case there are other ideas > out there or others who can help with the development. > > 1. I'll start out with the idea that would result in the biggest > structural change. I'm not sold on the field mapping UI for > associating form fields with payables. I think it would be much > more intuitive to create a "Payable Field" which could be added to > the form, and which would let you select a payable to be listed. > This payable field should optionally be able to set the price > instead of the quantity for the payable (needed for our use case, > where the user is making a donation of an arbitrary amount). The > getpaid adapter would then be responsible for finding all the > payable fields in the form and creating line items in the transient > shopping cart, much like it currently does based on the field > mapping stored on the adapter. > > 2. IMHO, getpaid.formgen should really be in the same repository as > the rest of the GetPaid codebase. I understand there's a licensing > issue here (getpaid is ZPL, and getpaid.formgen is GPL), but does > that really require that the two packages be in separate > repositories? To start contributing, I had to both get commit > rights to a special repository, and learn to use a new VCS > (mercurial)...isn't this kind of a high bar? If we can't use the > main getpaid repository, then perhaps the Plone collective? > > 3. This package really needs a working test infrastructure. Just to > try it out, I had to fix about 5 imports and remove several pdb > set_traces. These errors would have been trivially caught if we > were testing. Also, my confidence in the code to keep other > adapters from running if the payment fails is pretty low without a > test to prove that it works. > > 4. I ran into a bug where the form was unusable after I created the > GP-PFG adapter, until I edited and saved the adapter again. The > reason is that the adapter sets the execution condition for any > other action adapters in the form to check a property on the GP-PFG > adapter, and it was using its portal_factory id rather than the > final id. > > 5. We need to use something less brittle to refer to payables. > Currently the path is stored, I believe, which means that things > will break if the payable is ever moved to another folder. > > 6. It's great that getpaid.formgen recreates the fields for a > standard checkout form in PloneFormGen form, but the widgets need a > bit of work. Entering state and country in a text widget instead of > a selector kind of sucks. Also we need a credit card expiration > date widget that only includes month and year. > > 7. We need to force an https connection if that setting is set in > the GetPaid configlet. > > Hopefully with a bit of work we can get this into a state much more > ready for release. > > David Glick > Web Developer > ONE/Northwest > > New tools and strategies for engaging people in protecting the > environment > > http://www.onenw.org > [EMAIL PROTECTED] > work: (206) 286-1235 x32 > mobile: (206) 679-3833 > > Subscribe to ONEList, our email newsletter! > Practical advice for effective online engagement > http://www.onenw.org/full_signup > > > > David Glick Web Developer ONE/Northwest New tools and strategies for engaging people in protecting the environment http://www.onenw.org [EMAIL PROTECTED] work: (206) 286-1235 x32 mobile: (206) 679-3833 Subscribe to ONEList, our email newsletter! Practical advice for effective online engagement http://www.onenw.org/full_signup --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "getpaid-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/getpaid-dev?hl=en -~----------~----~----~----~------~----~------~--~---
