> > 1) Is the ioctl ACCEL_GETSUGGEST still in use ? 

We should reactivate it. It's a drawback not to have it.

> > In the Matrox KGIcon driver is stated that it is obsolete for KGI, 
> > and some debugging learned that it is never called in my ViRGE driver.

Yes. We should change that back.

>       AFAIK it is not is use anywhere, but as soon as we start doing
> anything complex with KGI driver (i.e. now), the suggest-strings feature will
> be very useful/necessary.  I am considering implementing this feature via
> 'cat /proc/gfx[n]/suggest' or something similar.

I don't recommend that. I'd like to have that call in the primary command
path, which is just about all a KGI-using module should need to know for
startup purposes. This will help tremendously when porting LibGGI to other
architectures, as only a single API call needs to be overloaded.

> not quite that easy.  I just looked at LibGGI2D and it does not have a
> display/ subsystem at all yet, and no default/kgi subsystem either.  Both
> will have to be added before LibGGI2D can cleanly overload the accelerations
> of LibGGI's fbdev and genkgi targets.  Still not all that hard, though.

Yep. Is LibGGI2D actively maintained right now ? Thomas ? Still there ?
If not, I'd suggest to have it rewritten by those adding actual 2D accel
support to their drivers. Would also resolve the license issue.

>       Now you have your KGI functionality in LibGGI2D.  But, it is a
> generic functionality - all KGI drivers must be handled the same way (as in
> LibGGI right now), because you do not have any genkgi sub-libraries to handle
> the features of the individual KGI drivers or driver families (e.g. S3's
> STREAMS).  To fix this, we need a genkgi.conf file for LibGGI2D, some sublib

I think that is overdoing it a little, isn't it ? I'd just stick that into
the main libs config file.

> code (kgi/s3-streams.c or similar), and a GetAPI function in the genkgi
> target code to load the sublibs.  Also, you either need special-case KGI
> driver detection code in the genkgi target or suggest-string parsing in order
> to know what type of KGI driver you are looking at.

You don't need to parse it actually. You just insert the suggest strings
into the GetAPI chain and are done with it.

> > 3) Where in the directorystructure must I implement my S3 ViRGE libggi2d &
> > libggi3d libs ? I couldn't find any suitable location in my CVS snapshot.

> libggi2d/default/kgi/mode.c
> libggi2d/default/kgi/visual.c
> libggi2d/default/kgi/genkgi.conf.in
> libggi2d/default/kgi/s3/gens3.c
> libggi2d/default/kgi/s3/streams/genstreams.c
> libggi2d/default/kgi/s3/streams/trio_streams.c
> libggi2d/default/kgi/s3/streams/virge_streams.c
> libggi2d/default/kgi/s3/streams/savage4_streams.c

Actually the "vendor" branch was intended for those drivers, but ...

CU, ANdy

-- 
= Andreas Beck                    |  Email :  <[EMAIL PROTECTED]> =

Reply via email to