[EMAIL PROTECTED] (Christoph Egger) writes:
> Hi!
>
> I've just cleaned up the libggi-code a bit. I created and attached a
> patch.
> Anyone here to commit it?
Nice work, I'd like to request some minor changes though:
> diff -uNr degas/lib/libggi/display/monotext/visual.c
>20000521-devel/degas/lib/libggi/display/monotext/visual.c
> --- degas/lib/libggi/display/monotext/visual.c Tue Apr 25 07:07:11 2000
> +++ 20000521-devel/degas/lib/libggi/display/monotext/visual.c Wed May 24 19:15:55
>2000
> @@ -34,16 +34,18 @@
> #include <ggi/display/monotext.h>
>
>
> -static gg_option options[] =
> +static gg_option monotext_options[] =
As these are all static variables I'd actually be most grateful if you
would change all files to simply use 'options' instead of '<name>_options'.
> diff -uNr degas/lib/libggi/display/palemu/visual.c
>20000521-devel/degas/lib/libggi/display/palemu/visual.c
> --- degas/lib/libggi/display/palemu/visual.c Tue Apr 25 07:07:12 2000
> +++ 20000521-devel/degas/lib/libggi/display/palemu/visual.c Wed May 24 18:31:39
>2000
[snip]
> @@ -78,8 +82,12 @@
> }
>
> if (args) {
> +#if 0 /* Why 3 options? */
> args = ggParseOptions((char *) args, palemu_options, 3);
> -
> +#endif
Looks like a copy-n-paste error, just remove the old code.
//Marcus
--
-------------------------------+------------------------------------
Marcus Sundberg | http://www.stacken.kth.se/~mackan
Royal Institute of Technology | Phone: +46 707 295404
Stockholm, Sweden | E-Mail: [EMAIL PROTECTED]
