> Attached is an implementation of giiSplitInputs; I was just able
> to verify it working.
Great - TNX.
> /* FIXME! We should alow this to be or-ed in */
> event->any.origin = GII_EV_ORIGIN_SENDEVENT;
> I would propose an alternative solution: don't do this. Depricate
> the use of any.origin when trying to find out if an event is
> real or counterfeit, instead, change the docs to tell people
> to check if any.target == GII_EV_TARGET_QUEUE (or if there is another
> legitimate use for this, create a new special value.)
Hmm - o.k. - don't think it would make a big difference. Was probably
influenced by X when writing this.
Basically it doesn't matter which field to check, and the field is rarely
checked anyway, as only few apps have to care.
> - printf("Doing test of input-pcjoy.\n");
> - if ((inp2=giiOpen("input-pcjoy",NULL)) == NULL) {
Good idea - very very bad source that i wrote there *g*
> - if (!inp) {
> + if (inp == NULL) {
Hmm - o.k. if you like it better. But AFAIK according to K&R and ANSI,
!inp is a perfectly legitimate and safe check for ==NULL when applied to
a pointer
> +int giiSplitInputs(struct gii_input *inp, struct gii_input **newhand,
> + uint32 origin, uint32 flags)
:-) Again I trust you on that one.
I assume you will add a few functions/macros making use of the new split
functionality to LibGGI as well ?
CU, Andy
--
= Andreas Beck | Email : <[EMAIL PROTECTED]> =
