Great, thanks!
On Thu, Aug 22, 2013 at 2:09 PM, Simon Marlow <marlo...@gmail.com> wrote: > Fixed atomicinc too. > > Cheers, > Simon > > > On 22/08/13 19:58, Simon Marlow wrote: > >> Sorry! Just pushed the fix. atomicinc was also failing for me, I >> assumed it was nothing to do with me. Perhaps not. I'll look into it. >> >> Cheers, >> Simon >> >> On 22/08/13 19:35, Austin Seipp wrote: >> >>> Simon, >>> >>> While validating the changes for #8144, I noticed there were several >>> failures that seem like a result of your recent commits (amd64/Linux): >>> >>> Unexpected failures: >>> . T4059 [bad stderr] (normal) >>> . T4850 [bad stderr] (normal) >>> . T5423 [bad stderr] (normal) >>> . T7037 [bad stderr] (normal) >>> . atomicinc [exit code non-0] (normal) >>> . outofmem [bad stderr] (normal) >>> . outofmem2 [bad stderr] (normal) >>> >>> I see several of the these fail, like: >>> >>> =====> T7037(normal) 1205 of 3760 [0, 6, 0] >>> cd ./rts && $MAKE -s --no-print-directory T7037 </dev/null >>> >T7037.run.stdout 2>T7037.run.stderr >>> Actual stderr output differs from expected: >>> --- /dev/null2013-08-15 19:58:16.771097011 -0500 >>> +++ ./rts/T7037.run.stderr2013-08-**22 13:27:33.531638515 -0500 >>> @@ -0,0 +1 @@ >>> +Makefile:74: >>> xxx/home/a/ghc/ghc-pristine/**libraries/base/dist-install/**buildxxx >>> *** unexpected failure for T7037(normal) >>> >>> This is because in 269c89062dd5b6d2b8bc4d41e5dca0**eca2308d02, you >>> added: >>> >>> +$(warning xxx$(BASE_DIR)xxx) >>> >>> Which I presume is perhaps left-over debugging cruft? >>> >>> I also see this failure: >>> >>> $ make TEST="atomicinc" >>> ... >>> =====> atomicinc(normal) 15 of 41 [0, 0, 0] >>> cd . && '/home/a/ghc/ghc-pristine/**inplace/bin/ghc-stage2' >>> -fforce-recomp >>> -dcore-lint -dcmm-lint -dno-debug-output -no-user-package-db -rtsopts >>> -fno-ghci-history -o atomicinc atomicinc.c -no-hs-main >>> >atomicinc.comp.stderr 2>&1 >>> Compile failed (status 256) errors were: >>> Warning: -rtsopts and -with-rtsopts have no effect with -no-hs-main. >>> Call hs_init_ghc() from your main() function to set these options. >>> atomicinc.o: In function `main': >>> atomicinc.c:(.text+0x20): undefined reference to `atomic_inc' >>> atomicinc.c:(.text+0x60): undefined reference to `atomic_dec' >>> collect2: error: ld returned 1 exit status >>> >>> >>> But I'm not sure what's causing it, since this hasn't been touched in a >>> while. >>> >>> -- >>> Regards, >>> Austin - PGP: 4096R/0x91384671 >>> >> >> > -- Regards, Austin - PGP: 4096R/0x91384671
_______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://www.haskell.org/mailman/listinfo/ghc-devs
