Bartosz left a note in the diff about it being faster this way: https://github.com/niteria/deterministic-fvs/blob/master/results.txt#L83-L89
But yeah, I would have also thought it better eta-reduced. On Thu, Dec 3, 2015 at 10:43 AM, Richard Eisenberg <[email protected]> wrote: > Hi devs, > > I'm (once again) merging master into my type=kind branch. I see that we now > have tyVarsOfTypeAcc :: Type -> FV, distinct from tyVarsOfType :: Type -> > TyVarSet. I trust that this new version is more performant. However, I have a > question: in the implementation of these functions, the three extra FV > parameters (fv_cand in_scope acc) are bound and passed each time. > > Why? > > I've always understood that eta-reducing in function definitions is better > than expanding. Or is this just a style choice? > > Thanks, > Richard > _______________________________________________ > ghc-devs mailing list > [email protected] > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs _______________________________________________ ghc-devs mailing list [email protected] http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
