Austin: can you report this bug with the Phabricator people please. For committers: don't use 'arc land' to land patches from others!
If this has happened to you in the past, could you please let me know. I am soon updating the contributors list on https://ghc.haskell.org/trac/ghc/wiki/TeamGHC, and would like it to be complete. These are the patches that I'm aware of that were misattributed this year: D600: Brian McKenna -> Erik de Castro Lopo D971: Bernard Desmyter -> Thomas Miedema D974: Zejun Wu -> Simon Marlow #11209: John Paul Adrian Glaubitz -> Sergei Trofimovich Thanks On Wed, Oct 29, 2014 at 8:21 AM, Joachim Breitner <[email protected]> wrote: > Hi, > > I was just about to apply a DR by David. First I ran > $ arc patch D390 > which put me on a feature branch. Then I reworded the commit with > $ git commit --amend > and then I tried to land it with > $ arc land > Luckily I also passed --hold... > > It even asked me if I want to land the commit although I am not the > author: > > This branch has revision 'D390: Reorder GHC.List; fix performance > regressions' but you are not the author. Land this revision by dfeuer? > [y/N] y > > But it still put me in the author field: > > $ git show HEAD > commit a387c359b99667ce55016de3816b5d9873a155db > Author: Joachim Breitner <[email protected]> > Date: Wed Oct 29 08:17:05 2014 +0100 > > Reorder GHC.List; fix performance regressions > > Summary: > Rearrange some oddly placed code. > > (and undid my commit message changes....) > > Did I do something wrong? > > Anyways, it said something along the lines of > Cleaning up feature branch... > (Use `git checkout -b 'arcpatch-D390' > 'a3ceb0e7f44d53f728fb8bd0dfb4c97297818029'` if you want it > back.) > so with > $ git commit --amend -C a3ceb0e7f44d53f728fb8bd0dfb4c97297818029 > I was able to get the edited commit message with the right author back. > > > Greetings, > Joachim > > -- > Joachim “nomeata” Breitner > [email protected] • http://www.joachim-breitner.de/ > Jabber: [email protected] • GPG-Key: 0xF0FBF51F > Debian Developer: [email protected] > > > _______________________________________________ > ghc-devs mailing list > [email protected] > http://www.haskell.org/mailman/listinfo/ghc-devs > >
_______________________________________________ ghc-devs mailing list [email protected] http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
