Everyone: please take a look. Luke
Very good. · I think it’s fine to work from your repo; no need to use the main repo. · One big patch is fine. The exception is late lambda-lifting which would best be done separately. · Can you identify any bits that you are less happy with? · Before long, can you put up nofib figures? Make a Trac ticket for this too. On Phab, you can have dialogue about “what does this line of code mean”. On Trac you can have longer-term strategic concerns. There isn’t a clear boundary. But Trac persists and Phab really doesn’t. We should talk about your question about floating. Simon From: Luke Maurer [mailto:[email protected]] Sent: 15 December 2016 10:52 To: Simon Peyton Jones <[email protected]> Subject: Phab diff up Okay, after some further cleanups, I've put up a Phabricator diff: https://phabricator.haskell.org/D2853 (Has some lint failures, but I figure better to put it up sooner … will fix after I get some sleep) Was going to push to a branch in the official GHC repo, too, but I don't think I have push access? Anyway, should I try and split it up into pieces? Hard to see how that would work, given how many interconnected pieces there are. I suppose if you apply the changes to Core Lint last, it might work … Also, the patch includes the stuff from the late lambda-lifting branch, which is perhaps more than we want to push at once! Certainly that much is splittable, if desired. I'm also just not as happy with that code. - Luke
_______________________________________________ ghc-devs mailing list [email protected] http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
