Hey Ben, Looks good to me for the most part! I think that you should include a link to the Newcomers page [1] as a whole, even though it has some overlap with the quick start guide and you’ve included a link to the ‘Finding a Ticket’ subsection therein.
I also think that a few more pointers on what is hoped for in a review (under ‘Reviewing Patches’) could be helpful for those looking to get involved! Code review styles and expectations can vary greatly, so some more info here would be good. Best, _ara [1] https://ghc.haskell.org/trac/ghc/wiki/Newcomers > On 26 Sep 2017, at 21:58, Ben Gamari <[email protected]> wrote: > > Hello everyone, > > Today I sat down and wrote a CONTRIBUTORS.md document for the ghc > repository. This is recommended by GitHub to ensure that contributors > can easily discover the first steps to contributing to the project. > Moreover, it provided a nice blank slate to summarize the existing > contributor documentation. > > It would be greatly appreciated if you could give it [1] a read-through > and leave your feedback. > > Cheers, > > - Ben > > > [1] https://phabricator.haskell.org/D4037 > https://github.com/bgamari/ghc/blob/contributing/CONTRIBUTING.md > _______________________________________________ > ghc-devs mailing list > [email protected] > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
_______________________________________________ ghc-devs mailing list [email protected] http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
