This is precisely the problem I was worried about in April.

https://mail.haskell.org/pipermail/ghc-devs/2019-April/017493.html

Any fix should ensure adding a test to make sure it doesn't happen again.

Cheers,

Matt

On Mon, Sep 16, 2019 at 10:38 PM Shayne Fletcher via ghc-devs
<[email protected]> wrote:
>
> Hi Sebastian,
>
> On Mon, Sep 16, 2019 at 5:23 PM Sebastian Graf <[email protected]> wrote:
>>
>> Hi Shayne,
>>
>> Sorry to hear that! We didn't consider modularity at all and I would be 
>> happy to try to refactor in a way that would allow `ghc-lib-parser` to be 
>> properly separated again.
>> I'm fairly certain that I didn't directly touch anything parser related, but 
>> apparently the new cyclic import of PmOracle within TcRnTypes (which is also 
>> exposed from `ghc-lib-parser`) pulled in the other half of GHC.
>> I'll see if I can fix that tomorrow, if only by extracting a separate 
>> `Types`-style module.
>>
>
> That sounds awesome. Tremendous. Thank-you! Please feel free to reach out to 
> me if there's anything I can do to help your analysis[*]!
>
> [*] For the record, the procedure for calculating the `ghc-lib-parser` 
> modules is a little complicated by there needing to be some generated 
> equivalents of `.hsc` files present for this to work but the procedure is at 
> the end of the day just `ghc -M` invoked over `Parser.hs`.
>
>>
>> Cheers,
>> Sebastian
>
>
> Fingers crossed and all the best!
>
> --
> Shayne Fletcher
> Language Engineer / +1 917 699 7663
> Digital Asset, creators of DAML
>
> This message, and any attachments, is for the intended recipient(s) only, may 
> contain information that is privileged, confidential and/or proprietary and 
> subject to important terms and conditions available at 
> http://www.digitalasset.com/emaildisclaimer.html. If you are not the intended 
> recipient, please delete this 
> message._______________________________________________
> ghc-devs mailing list
> [email protected]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
_______________________________________________
ghc-devs mailing list
[email protected]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

Reply via email to